fix(build): let the Windows payload guard account for the alternate app icons - #20
Merged
Merged
Conversation
…pp icons Blade's build failed with "Windows packaged payload contains 81 files; expected at most 80". The guard is a tripwire on accidental bloat (a stray node_modules or source tree landing in the package), and MT Code deliberately ships three alternate app icons on top of upstream's payload — the icon the user picks is applied to the running window. Raised the limit to 84 so the tripwire still has a tight margin. Model: Claude Opus 5, harness: Claude Code
github-actions
Bot
added
vouch:trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Windows leg of the fleet refresh failed on Blade:
WINDOWS_PACKAGED_PAYLOAD_FILE_LIMITis upstream's tripwire against accidental payload bloat — a straynode_modulestree or source directory landing in the package. MT Code intentionally adds three files on top of that payload: the alternate app icons (default / white-on-black / black-on-white), which the runtime applies to the window when the user picks one.Fix
Raised the limit to 84 and documented why, keeping the margin tight enough that the guard still catches real bloat.
Verification
vp test run scripts/build-desktop-artifact.test.ts— 50 passing.Model: Claude Opus 5, harness: Claude Code