fix(desktop): actually ship the alternate app icons - #13
Merged
Conversation
extraResources matchers run against the staged app tree, not the repo, so pointing at assets/munim copied nothing and the App icon setting had no files to switch to - the Dock kept the shipped icon however the picker was set. The icons are now staged into prod-resources like the other native resources, and the test spells out why every `from` must live inside the stage. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
vouch:trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extraResourcesmatchers run against the staged app tree, not the repo. Pointing one atassets/munimcopied nothing, soresources/app-iconsnever existed and the App icon picker had no files to switch to — the Dock kept the shipped icon whatever you chose.The icons are now staged into
prod-resourcesalongside the resource monitor and the desktop MCP, and the test says why everyfromhas to live inside the stage.