Skip to content

✨ Convert scf.while to jeff#1836

Draft
denialhaag wants to merge 2 commits into
mainfrom
jeff-while
Draft

✨ Convert scf.while to jeff#1836
denialhaag wants to merge 2 commits into
mainfrom
jeff-while

Conversation

@denialhaag

Copy link
Copy Markdown
Member

Description

This PR adds conversion patterns for converting between scf.while and jeff.while.

This PR should not be merged before PennyLaneAI/jeff-mlir#23 is merged and released.

Fixes #1707

Checklist

  • The pull request only contains commits that are focused and relevant to this change.
  • I have added appropriate tests that cover the new/changed functionality.
  • I have updated the documentation to reflect these changes.
  • I have added entries to the changelog for any noteworthy additions, changes, fixes, or removals.
  • I have added migration instructions to the upgrade guide (if needed).
  • The changes follow the project's style guidelines and introduce no new warnings.
  • The changes are fully tested and pass the CI checks.
  • I have reviewed my own code changes.

@denialhaag denialhaag added this to the MLIR Support milestone Jul 1, 2026
@denialhaag denialhaag self-assigned this Jul 1, 2026
@denialhaag denialhaag added enhancement Improvement of existing feature MLIR Anything related to MLIR labels Jul 1, 2026
@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

An error occurred during the review process. Please try again later.

✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch jeff-while

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improvement of existing feature MLIR Anything related to MLIR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ Convert scf.while to jeff

1 participant