Build fixes & cleanup in Makefile and CI - #91
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Preserve public C API tags and move the macOS platform check before the host build.
Review effort: Lite
Findings: 1
Open (2)
What changed in this PR
Updates Rust 1.98 pinning, CI/Docker build workflows, local artifact reproduction, and C API header formatting.
Changes:
- Pins Rust across toolchains, Docker, and CI.
- Adds unified multi-architecture Docker and local build targets.
- Regenerates the C API header and cleans repository ignore files.
| File | Summary |
|---|---|
rust-toolchain.toml |
Pins the Rust toolchain. |
README.md |
Documents local CI artifact reproduction. |
Makefile |
Adds platform and Docker build targets; macOS checks currently run after host compilation. |
Docker/linux.dockerfile |
Provides unified multi-architecture Linux builds. |
Docker/arm64.dockerfile |
Removes the superseded ARM Dockerfile. |
c-api/libvmexeccapi.h |
Regenerates and reformats C API declarations. |
c-api/build.rs |
Configures header formatting; tag removal causes a critical public API break. |
.gitignore |
Adds editor and OS exclusions. |
.github/workflows/rust-ci.yml |
Pins CI checks to Rust 1.98. |
.github/workflows/libvmexeccapi-build.yml |
Updates native artifact builds. |
.github/workflows/libvmexeccapi-build-linux-arm64.yml |
Uses the unified Linux Docker build. |
.dockerignore |
Reduces Docker build context. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Updates Rust 1.98 pinning, CI/Docker build workflows, local artifact reproduction, and C API header formatting.
Changes: