Skip to content

Build fixes & cleanup in Makefile and CI - #91

Merged
andrei-marinica merged 5 commits into
masterfrom
local-ffi-build
Sep 28, 2026
Merged

andrei-marinica merged 5 commits into
masterfrom
local-ffi-build

Conversation

@andrei-marinica

@andrei-marinica andrei-marinica commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor
What changed in this PR

Updates Rust 1.98 pinning, CI/Docker build workflows, local artifact reproduction, and C API header formatting.

Changes:

  • Pins Rust across toolchains, Docker, and CI.
  • Adds unified multi-architecture Docker and local build targets.
  • Regenerates the C API header and cleans repository ignore files.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Preserve public C API tags and move the macOS platform check before the host build.

Review effort: Lite
Findings: 1 High severity · 1 Medium severity

Open (2)
What changed in this PR

Updates Rust 1.98 pinning, CI/Docker build workflows, local artifact reproduction, and C API header formatting.

Changes:

  • Pins Rust across toolchains, Docker, and CI.
  • Adds unified multi-architecture Docker and local build targets.
  • Regenerates the C API header and cleans repository ignore files.
File Summary
rust-toolchain.toml Pins the Rust toolchain.
README.md Documents local CI artifact reproduction.
Makefile Adds platform and Docker build targets; macOS checks currently run after host compilation.
Docker/​linux.dockerfile Provides unified multi-architecture Linux builds.
Docker/​arm64.dockerfile Removes the superseded ARM Dockerfile.
c-api/​libvmexeccapi.h Regenerates and reformats C API declarations.
c-api/​build.rs Configures header formatting; tag removal causes a critical public API break.
.gitignore Adds editor and OS exclusions.
.github/​workflows/​rust-ci.yml Pins CI checks to Rust 1.98.
.github/​workflows/​libvmexeccapi-build.yml Updates native artifact builds.
.github/​workflows/​libvmexeccapi-build-linux-arm64.yml Uses the unified Linux Docker build.
.dockerignore Reduces Docker build context.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread c-api/build.rs Outdated
Comment thread Makefile Outdated
@andrei-marinica
andrei-marinica merged commit c0478c6 into master Sep 28, 2026
7 checks passed
@andrei-marinica
andrei-marinica deleted the local-ffi-build branch September 28, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants