Repository navigation
Private range #10
Description
With multiformats/multicodec#191 merged, it is now possible to use private ranges with multicodec.
Can this library support private ranges?
I think this would mean being able to register additional custom types which will be allocated into the private range. And then being able to add the multicodec for the private keys.
Activity
CMCDragonkai commentedon Nov 9, 2020
So I've just gone through
py-cidandpy-multicodec.I can see that it's not possible to make use of any custom codecs. The functions
multicodec.add_prefixandmulticodec.is_codecis being used to check if my codec is legitimate.I suggest that
py-multicodecis given the feature to update the constants table at runtime, so it's possible for users to add their own entries to the tables inconstants.py, or even merge with theconstants.py.This would enable this library to take advantage of the private range, and even use py-multicodec or more.
@dhruvbaldawa
dhruvbaldawa commentedon Dec 1, 2020
Hi @CMCDragonkai,
I have taken the first stab at this problem here: #12
We can update
py-cidto check for private ranges as well, and I guess it should fix your problem.I feel that we can make this change without breaking the backward compatibility, while being extensible, let me know what you think of it.
CMCDragonkai commentedon Dec 6, 2020
Did you see my MR #11?
CMCDragonkai commentedon Dec 6, 2020
I had to turn multicodec into an object so I could register my private codec to it.
rvagg commentedon May 9, 2023
closing from inactivity, archiving repository