feat: add admin-only force-resolve market function with idempotency-key support#2
Open
muffti123 wants to merge 1 commit into
Open
feat: add admin-only force-resolve market function with idempotency-key support#2muffti123 wants to merge 1 commit into
muffti123 wants to merge 1 commit into
Conversation
Implements an admin-only force_resolve_market entrypoint on the PredictifyHybrid contract that can resolve a market BEFORE its end_time, with strict idempotency-key replay protection. Closes Predictify-org#648 === API Changes === New function: force_resolve_market(env, admin, market_id, winning_outcomes, reason, idempotency_key) -> Result<(), Error> Key differences from existing resolve_market_manual: - Bypasses end_time check (resolves at any time) - Returns Result<(), Error> instead of panicking - Requires non-empty 'reason' (stored in audit trail) - Requires a unique idempotency_key (string, e.g. UUID) per market - Supports multiple winning outcomes (Vec<String>) === New Error Codes === ForceResolveReplayed (517) - idempotency key already used ForceResolveReasonEmpty (518) - empty reason string === New Events === ForceResolvedEvent (topic 'frc_rs') emitted on success === New Audit Action === AuditAction::MarketForceResolved === New Module === force_resolve.rs - ForceResolveManager for idempotency storage === Files === M src/err.rs - error variants, classification, recovery M src/events.rs - event struct + ForceResolvedEvent emitter M src/lib.rs - force_resolve_market function + test mod M src/audit_trail.rs - MarketForceResolved audit action A src/force_resolve_tests.rs - comprehensive tests
2ce1670 to
217cbb1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements an admin-only
force_resolve_marketentrypoint that allows the contract admin to resolve any market (Active, Ended, Disputed, or already Resolved) to an arbitrary set of winning outcomes, bypassing oracle resolution. Idempotency is guaranteed via a caller-supplied key, making the operation safe to retry.Closes Predictify-org#179
New Files
contracts/predictify-hybrid/src/force_resolve.rsForceResolveRecordstruct andForceResolveManagerwith persistent idempotency storagecontracts/predictify-hybrid/src/force_resolve_tests.rsModified Files
src/lib.rsmod force_resolve,mod force_resolve_tests, andforce_resolve_marketentrypointsrc/err.rsForceResolveAlreadyUsed = 435with full severity/category/recoverability classificationsrc/resolution.rsForceResolvevariant toResolutionMethodenum (confidence 100)admin.rs,bets.rs,fees.rs,oracles.rs,storage.rs, etc.)Design Decisions
Stringstored as(symbol_short!("frc_rslv"), market_id, key)— safe for retriesend_time)"ForceResolve"with confidence 100 (highest authority)API
Returns nothing. Panics on error (Standard Soroban pattern).
try_*variant returns wrapped contract error codes.Validation Order (in entrypoint)
InvalidInput(401)MarketNotFound(101)InvalidOutcome(108)Tests (13 total, all passing)
Error::UnauthorizedError::MarketNotFoundError::InvalidOutcomeError::InvalidInput