Repository navigation
Drop the unreachable date branch in _is_incidental_page - #113
Merged
Merged
Conversation
The branch matching a date in file-name form (2025_10_10, 2025-10-10,
2025/10/10) never ran: such a name holds digits and separators only, and
the rule for names without a letter returns first. Digits are never
letters, so no input reaches it. Removing it leaves all 3265 tests green.
The behaviour the comment promised stays, now stated at the rule that does
the work. ARTEFACTS gains 2025-10-10 and 2025/10/10, so each spelling is
pinned by a test and not by a comment. Narrowing the no-letter rule so that
separators count as letters makes the test fail on 2025_10_10 and
2025/10/10. 2025-10-10 is also caught by the ticket-number rule
(\d{3,}-), so it stays pinned either way.
No behaviour change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No behaviour change.
The branch matching a date in file-name form (
2025_10_10,2025-10-10,2025/10/10) never ran. Such a name holds digits and separators only, and the rule for names without a letter returns first. Every character\dmatches is a Unicode decimal digit (660 of them; none is a letter), and-_/are not letters either, so no input reaches it. With the branch removed all 3265 tests still pass.The behaviour the comment promised stays, now stated at the rule that does the work.
ARTEFACTSgains2025-10-10and2025/10/10, so each spelling is pinned by a test instead of a comment. Narrowing the no-letter rule so that separators count as letters makes the test fail on2025_10_10and2025/10/10;2025-10-10is also caught by the ticket-number rule (\d{3,}-), so it stays pinned either way.Independent of #112; the two touch
test_read_only_commands_smoke.pyin different places and merge without conflict (checked, 3265 tests on the combined tree).