Repository navigation
fix: add integer overflow check in VectorTable.c - #485
Open
anupamme wants to merge 1 commit into
Conversation
The createVectorTable function allocates memory using 'sizeof(double)*np' without checking for integer overflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix high severity security issue in
ModelicaByExample/Functions/Interpolation/source/VectorTable.c.Vulnerability
V-001ModelicaByExample/Functions/Interpolation/source/VectorTable.c:23Description: The createVectorTable function allocates memory using 'sizeof(double)*np' without checking for integer overflow. If np is sufficiently large (e.g., near SIZE_MAX / sizeof(double)), the multiplication can overflow, resulting in a small allocation. Subsequent writes to table->x[i] and table->y[i] will write beyond the allocated buffer, causing heap corruption.
Evidence
Exploitation scenario: An attacker who controls the np parameter provides a value like 0x2000000000000000 (on 64-bit systems).
Scanner confirmation: multi_agent_ai rule
V-001flagged this pattern.Threat Model Context
This is a local CLI tool - exploitation requires the attacker to control command-line arguments or input files.
Changes
ModelicaByExample/Functions/Interpolation/source/VectorTable.cBehavior Preservation
The change is scoped to 1 file on the vulnerable path.
Automated security fix by OrbisAI Security