Repository navigation
Omit missing optional compose overrides - #176
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The centralized existence check preserves editor paths and is covered across affected command-building flows.
0 open findings
What changed in this PR
Omits nonexistent optional override files from Compose command inputs while preserving their editor/write target paths.
Changes:
- Filters missing override files from Compose arguments.
- Updates and adds unit coverage for direct, extra-file, up, and down flows.
| File | Description |
|---|---|
source/compose.manager/include/Util.php |
Includes optional overrides only when present. |
tests/unit/StackInfoTest.php |
Updates expected Compose paths. |
tests/unit/ExtraComposeFilesTest.php |
Verifies extra-file ordering without an override. |
tests/unit/ComposeCommandBuilderTest.php |
Tests missing overrides for up/down actions. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that missing optional compose overrides are not included in the build process, while maintaining the preferred override path for editor operations. This change improves the handling of compose files in older and manually created stacks.