Repository navigation
fix(compatibility): require Unraid 6.12 and remove legacy WebUI patches - #173
Merged
Merged
Conversation
Align documented requirements with the plugin's PHP 8 dependency. Remove obsolete patch scripts, assets, installer hooks, settings and action handling, while retaining the pre-7.0 Ace fallback and Git patch features. Add installer compatibility regression coverage for the minimum version and Ace fallback. Fixes #170.
There was a problem hiding this comment.
🟢 Approval recommended
The compatibility requirement and legacy removals are consistent, with no unresolved blocking findings.
0 open findings
What changed in this PR
Raises Compose Manager’s minimum supported Unraid version to 6.12.0 and removes obsolete WebUI patching support.
Changes:
- Updates installer requirements and documentation.
- Removes legacy patches, scripts, settings, and handlers.
- Adds installer compatibility tests while retaining the Ace fallback.
| File | Description |
|---|---|
| tests/unit/patch.bats | Removes obsolete patch-helper tests. |
| tests/unit/InstallerCompatibilityTest.php | Tests minimum version and retained Ace fallback. |
| tests/unit/ComposeFilterTest.php | Updates a filtering comment only. |
| source/pkg_build.sh | Updates package description wording. |
| source/compose.manager/scripts/patch.sh | Deletes legacy patch utility. |
| source/compose.manager/scripts/install-patch.sh | Deletes patch lifecycle script. |
| source/compose.manager/patches/6.9/docker_client.patch | Deletes Unraid 6.9 patch. |
| source/compose.manager/patches/6.11/docker_client.patch | Deletes Unraid 6.11 patch. |
| source/compose.manager/patches/6.10/docker_client.patch | Deletes Unraid 6.10 patch. |
| source/compose.manager/include/Exec.php | Removes patch execution handler. |
| source/compose.manager/default.cfg | Removes patch setting default. |
| source/compose.manager/compose.manager.settings.page | Removes patch controls and supporting logic. |
| README.md | Documents the new minimum version. |
| docs/user-guide.md | Clarifies filtering and removes patch instructions. |
| docs/getting-started.md | Updates installation requirements. |
| docs/configuration.md | Removes legacy patch documentation. |
| compose.manager.plg | Enforces minimum version and removes patch hooks. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes support for Unraid versions earlier than 6.12.0, simplifying the codebase and documentation by eliminating legacy patching logic and UI elements related to older Unraid releases. All references to the legacy "Patch Web UI" feature and compatibility code for pre-6.12 Unraid have been removed, reflecting the new minimum version requirement of Unraid 6.12.0 (which includes PHP 8). Documentation has also been updated to clarify the new requirements and streamline user instructions.
Minimum version and requirements update:
README.md,docs/getting-started.md, andcompose.manager.plg. [1] [2] [3]Removal of legacy patching support:
compose.manager.plg. [1] [2]PATCH_UIsetting and associated code, UI elements, and AJAX handlers fromsource/compose.manager/compose.manager.settings.pageanddefault.cfg. [1] [2] [3] [4] [5] [6] [7] [8]runPatchAJAX handler fromsource/compose.manager/include/Exec.php.Documentation updates and simplification:
docs/configuration.md,docs/user-guide.md) to remove references to the legacy patch feature, clarify the new behavior for hiding Compose containers, and explain that no patching is needed on Unraid 6.12+. [1] [2] [3] [4] [5]These changes ensure Compose Manager is streamlined for Unraid 6.12.0 and later, reducing maintenance and potential confusion for users.
Fixes #170