Repository navigation
ci(pstack): run macOS outside CI gate, since its runners can starve it - #27
Merged
Merged
Conversation
GitHub's macOS arm64 runners failed to pick up the /bin/bash install job three times in a row today, so CI gate failed on main and on #22 even after #25 cut macOS to one job. pstack-macos.yml now runs that job on every push to main, daily, and on demand, outside the gate, and a test keeps its steps the same as the gated Ubuntu install job's.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#25 cut the macOS install job to one,
/bin/bash, because the other one kept failing to get a runner. Today the/bin/bashjob failed the same way three times in a row ("The job was not acquired by Runner of type hosted even after multiple attempts"): once onmainafter #25 merged, and twice on #22. GitHub cancels a job that waits about 15 minutes for a macOS runner.CI gatetreats a cancelled job as a failure, and themainruleset requires the gate with no bypass, so each shortage blocks every merge and release until a retry gets lucky.What changes
pstack-ci.yml: the install job runs on Ubuntu only. Every job in this file still feedsCI gate.pstack-macos.yml: the same install steps onmacos-latestwith/bin/bash, on every push tomain, daily at 06:23 UTC, and on demand. It has nopull_requesttrigger, so it never adds a check to a pull request. A newer commit cancels a run that is still waiting for a runner, so a burst of merges doesn't queue several runs for scarce runners.CiWiringTestnow fails if any gated job runs on macOS. The newMacosWorkflowTestfixes the triggers, the read-only permissions, and the cancel-on-newer concurrency group, and checks that the macOS steps match the gated Ubuntu install job's steps except for/bin/bash. Without that check, the two copies could drift apart now that they live in separate files.port/README.md: the CI section describes the new workflow, its trade-off, and how to test a branch on macOS before merging (gh workflow run pstack-macos.yml --ref <branch>).Risk
A bug that shows up only on macOS (bash 3.2, BSD
statordate) can now merge and ship in a release before its macOS run reports. The run onmainstill catches it within hours, but the fix lands after the release.Proof
pull_requesttrigger, andmain's currentpstack-ci.ymlwith macOS in the gate.install_test.shpasses, andcheck.pyreports 0 problems. Both workflows parse, with the triggers and runners listed above.