Repository navigation
Release 2.3.11: bounded diagnostic DSP capture - #156
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When SNESRECOMP_DSPOUT is set, loading an earlier DSP ring could previously emit almost 16 GiB. This patch release pins the bounded recorder fix from snesrecomp #233/#234 and its nonmodal scripted-save qualification support. Prior engine features, native implementation selections and game defaults are preserved.
Validation: Windows x64 build; supported archive packaging and DLL closure; normal startup, reset and current-build save/load; a fresh process recording across two loads of the same current-build fixture. All passed with muted audio and a disposable profile. The exact recorder's ROM-free wrap, overrun, generation and I/O-error tests also pass. A real boot ring overrun is rejected as invalid capture rather than emitting repeated data.