Repository navigation
Wh 011 permissions - #5
Merged
Merged
Conversation
…nagers, and a protected main Workspace admins can now manage permissions: change a member's role, and create, edit and delete custom roles (up to 3) with permissions grouped by area, plus choose the default role for new members. Nobody can grant or manage more than they hold: invites, role changes and role edits are all limited to roles within your own permissions, the Owner role is locked, and you can't edit your own role. Unknown permissions are rejected, and built-in role names are reserved. Add a Manager role (Member + approve leave + fulfil documents) to every workspace, and Groups on the Team page: teams with members and managers, where only people who can approve leave can be managers. Postgres row-level security and composite foreign keys keep every group inside its own workspace. Protect main with a GitHub ruleset: changes arrive by pull request, both CI checks must pass on an up-to-date branch, squash merge only. After a commit, every next ticket at the top priority moves to in progress, deleting a branch skips the push gate, and the translation check understands dotted dynamic keys. Refs: WH-011, WH-058, WH-077, WH-078
Roles is a real page now; stop expecting coming-soon there. Reset the feature branch off the unrelated Spring Boot develop history, delete origin/develop, and require e2e in reviews for user-facing tickets. Co-authored-by: Cursor <cursoragent@cursor.com>
The shell test still expected the coming-soon placeholder on
/s/{slug}/roles, which WH-011 replaced with the real Roles page; it
now checks the real page instead. Reviews now include an e2e run for
user-facing tickets. Remove the WH-011, WH-058, WH-077 and WH-078
tickets after their commit, and make workspace setup and holidays
the next milestone (P1).
Refs: WH-079
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.