Repository navigation
WH-077: Avoid OOM in storage pixel-bomb test on CI - #3
Merged
Merged
Conversation
The fixture used sharp.create at 12k×12k, which OOMs when quality runs tests in parallel on GitHub. Claim oversized IHDR dimensions in a tiny PNG instead so limitInputPixels still rejects without allocating. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainCI run failed on@work-hub/storage:testwhen the pixel-bomb fixture allocated a 12k×12k image under parallel quality.limitInputPixelsstill rejects without OOM.Test plan
pnpm nx test storagelocallymainand confirm both jobs green onmainMade with Cursor