Local runs without a secrets.toml crash on st.secrets access (feedback widget) - #72
Merged
Conversation
…k widget) Implements #70 (agent-loop / pi).
CodeQL flagged the `st.empty` stub as a lambda wrapping a callable (code-scanning alert 236). `info_messages.append` and `object` can be passed directly; behaviour is unchanged. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
# Conflicts: # tests/test_scenario_page.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated by agent-loop — pi worked this issue on a fresh clone of
mrwadams/attackgen; changes were gated outside the agent on agent-1.Closes #70
How to test
Then open the printed local URL.
Confirm each acceptance criterion:
secrets.tomlpresent anywhere, Welcome and every scenario page render without aStreamlitSecretNotFoundErrorLANGCHAIN_API_KEYis absent, the feedback widget still renders and no LangSmith call is attemptedLANGCHAIN_API_KEYis present in secrets, existing LangSmith feedback behaviour is unchangedst.secretsaccess incore/feedback.pyis guarded (three access sites today)StreamlitSecretNotFoundError, not merely a mocked "key absent" membership (the existingtests/test_scenario_page.pymock hides this failure mode)Gates (non-authoritative)