Repository navigation
Add stable result checks so Dependabot auto-merge waits for CI - #350
Merged
Merged
Conversation
The build jobs use a path-filtered matrix, so their check names change with each PR ("Build and test (reactive/helidon)" when it runs, "Build and test" when skipped). That makes them impossible to require in a branch rule. Each workflow now ends with a result job that always reports under one name and fails if any earlier job failed or was cancelled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Auto Merge workflow fails on most minor Dependabot PRs (#343, #339, #336) with `Protected branch rules not configured for this branch`. When it doesn't fail, it's worse: `gh pr merge --auto` merges the PR immediately because nothing is required, so PRs like #348 merged 15 seconds after opening, before any build ran.
Real auto-merge needs required status checks on main. The build jobs can't be required as-is, because their path-filtered matrix reports a different check name per PR.
This adds a `result` job to each CI workflow that always reports under a stable name and fails if any earlier job failed or was cancelled:
After this merges, main needs a ruleset that requires those four checks. Then `gh pr merge --auto` will wait for CI instead of erroring or merging early.