Conversation
yt-dlp builds the cookies field of each format for the url of that format and leaves out the Domain attribute when the cookie has an empty domain in its jar. Cookies imported from a browser can have one, and the jar then matches them against every url. Store every cookie the same way and default its domain to the host of the url the cookies were built for, which makes it a host-only cookie. The port and userinfo are stripped, since neither libcurl nor lavf matches a domain that includes them. A cookie that still has no domain because the url has no http host is dropped. This includes some cleanup of leftover implementation details of old lavf cookie option merge, removed in 6017d1f. Fixes: mpv-player#18506
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
yt-dlp builds the cookies field of each format for the url of that format and leaves out the Domain attribute when the cookie has an empty domain in its jar. Cookies imported from a browser can have one, and the jar then matches them against every url.
Store every cookie the same way and default its domain to the host of the url the cookies were built for, which makes it a host-only cookie. The port and userinfo are stripped, since neither libcurl nor lavf matches a domain that includes them. A cookie that still has no domain because the url has no http host is dropped.
This includes some cleanup of leftover implementation details of old lavf cookie option merge, removed in 6017d1f.
Fixes: #18506