Repository navigation
feat(sign): Linked the metadata docs in add-on submission errors - #3899
Open
aaronanish-t wants to merge 1 commit into
Open
aaronanish-t wants to merge 1 commit into
aaronanish-t wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3636
When AMO rejects a submission with a 4xx (usually missing or invalid metadata, like the missing
licensein the issue), the error now ends with a hint pointing to the docs rpl linked in the issue. Server errors (5xx) are unchanged.Example, for the error from the issue:
Changes:
fetchJson()takes an optionalerrorHintthat's appended to 4xx errors.doNewAddonSubmit()anddoNewAddonOrVersionSubmit()passSUBMISSION_ERROR_HINT.fetchJson()appending a hint.tests/unit/test-util/test.submit-addon.jspasses (68 tests). On Windows, the full unit suite has two failures intest.watcher.js, but they also fail intermittently on a cleanmastercheckout, so they're unrelated.@Rob--W, about the docs part of the issue (making it clear
licenseis required): should that be a separate PR to the Extension Workshop repo?