Skip to content

gcs: default external_account credential format to text in memory - #2889

Open
akasakariko wants to merge 3 commits into
mozilla:mainfrom
akasakariko:fix/gcs-external-account
Open

akasakariko wants to merge 3 commits into
mozilla:mainfrom
akasakariko:fix/gcs-external-account

Conversation

@akasakariko

@akasakariko akasakariko commented Oct 9, 2026 •

Copy link
Copy Markdown

reqsign-google 3.1.0 cannot load external_account credentials when credential_source omits format, although AIP-4117 defaults it to text
For credentials referenced by SCCACHE_GCS_KEY_PATH or GOOGLE_APPLICATION_CREDENTIALS, sccache now inserts the default text format in memory before passing them to OpenDAL without rewriting the original file
Explicit formats remain untouched, empty environment paths are ignored, and an upstream fix is tracked in apache/reqsign#910

Fixes #2884

Comment thread src/cache/gcs.rs
Comment thread src/cache/gcs.rs Outdated
Comment thread src/cache/gcs.rs Outdated
@codecov-commenter

codecov-commenter commented Oct 9, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.11321% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.75%. Comparing base (214cde1) to head (7a85e21).

Files with missing lines Patch % Lines
src/cache/gcs.rs 98.11% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2889      +/-   ##
==========================================
+ Coverage   77.66%   77.75%   +0.08%     
==========================================
  Files          72       72              
  Lines       41574    41732     +158     
==========================================
+ Hits        32290    32450     +160     
+ Misses       9284     9282       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@akasakariko

Copy link
Copy Markdown
Author

Addressed, PTAL. Thanks!

Comment thread src/cache/gcs.rs Outdated
Comment thread src/cache/gcs.rs Outdated
@akasakariko akasakariko changed the title gcs: support external account credentials without explicit format gcs: default external_account credential format to text in memory Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0.18.0: GCS backend can't load external_account (workload identity federation) credentials

3 participants