Repository navigation
Conversation
Mozilla Accounts is moving its Glean YAML files from packages/fxa-shared/metrics/glean/ to libs/shared/metrics/glean/src/registry/ (FXA-14711), next to the Subscription Platform files. Add the new paths for accounts_frontend and accounts_backend. Keep the old paths until the FxA move merges.
There was a problem hiding this comment.
🟡 Changes recommended
The new paths are absent until the FxA move and cause CI repository validation to fail; defer them or add a temporary exception.
1 open finding
What changed in this PR
Adds Mozilla Accounts Glean registry paths for the planned FxA metrics migration.
Changes:
- Adds two frontend and three backend registry paths.
- Retains existing legacy paths during migration.
| File | Summary |
|---|---|
repositories.yaml |
Registers new and legacy FxA Glean file locations. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| branch: main | ||
| metrics_files: | ||
| - packages/fxa-shared/metrics/glean/fxa-ui-metrics.yaml | ||
| - libs/shared/metrics/glean/src/registry/fxa-ui-metrics.yaml |
vbudhram
marked this pull request as draft
October 14, 2026 20:36
Author
|
Converting to draft. The Check Repos step needs the files to exist on fxa main first. FxA will add copies at the new paths (FXA-14778), then this PR will replace the old paths in one step. |
The FxA files now exist at libs/shared/metrics/glean/src/registry/ on mozilla/fxa main (mozilla/fxa#21516). Remove the old packages/fxa-shared/metrics/glean/ paths, so that the later removal of the old files in fxa does not break the scrape.
vbudhram
changed the title
vbudhram
marked this pull request as ready for review
October 14, 2026 21:09
1 of 5 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Had some help with AI to generate this PR, but FxA is moving the location of our configs as part of a larger refactor. Let me know if this is correct or if changes are needed. My understanding is once our files are moved, I will need a new PR to delete the old location.
Order:
glean-generatescripts at the new paths.Checks:
yamllint repositories.yamlpasses, andpytest tests/test_repositories_parser.pypasses (4 tests). The 5 raw URLs on fxamainreturn 200. Thefirefox-enterprise-desktoperror in "Check Repos" is also on probe-scrapermainand is not from this change.