Skip to content

Contributors: Exclude self-reviews from the dashboard - #4528

Open
ayshushus wants to merge 1 commit into
mozilla:mainfrom
ayshushus:2627-self-reject
Open

ayshushus wants to merge 1 commit into
mozilla:mainfrom
ayshushus:2627-self-reject

Conversation

@ayshushus

@ayshushus ayshushus commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Fix #2627

  • The counts still don't equal the number of strings a link returns.
  • The timeline counts ActionLog rows while the translate view lists entities.
  • In full-year mode, every month row links to the whole period.
  • Badges still count explicit self reviews.
  • Actions on disabled entities (and obselete projects) no longer count.
  • Exclusion on review_time is to avoid "No results" explicitly from self-reviews. This still doesn't fix the first point.

Edit:

  • There are many instances of "No results" for a variety of strings that this PR cannot fix.
  • The review dates for above strings are set to NULL so they are not linked to self-reviewed cases.
  • There are additional cases with ambiguity which are seen from fixing the full-year mode bug (point 3 from above).

@ayshushus
ayshushus marked this pull request as ready for review September 15, 2026 15:21
@ayshushus
ayshushus requested a review from mathjazz September 15, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Activity log: no results when clicking reviewed link for self-rejected suggestions

1 participant