Skip to content

Built-in pretranslation can store translations that still fail checks #4510

Description

@flodolo

Found while working on the pretranslation API.

pretranslate.py runs run_checks() on each pretranslation

failed_checks = run_checks(

On failure it retries once with preserve_placeables=True, but if the retry also fails, the result is stored anyway — nothing checks it again.

bulk_run_checks(Translation.objects.for_checks().filter(pk__in=translation_pks))

#4499 makes these warnings visible and keeps the translation out of sync, but the pretranslation is still created.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Fields

    Priority

    None yet

    Effort

    None yet

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions