Remove the "duplicated" Page.prototype.createAnnotationEvaluator method - #21817
Remove the "duplicated" Page.prototype.createAnnotationEvaluator method#21817Snuffleupagus wants to merge 1 commit into
Page.prototype.createAnnotationEvaluator method#21817Conversation
…thod The `Page.prototype.createAnnotationEvaluator` method is just a simple wrapper around a private method, hence we can just expose that one directly to avoid a tiny bit of unnecessary code duplication.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21817 +/- ##
==========================================
- Coverage 90.20% 90.19% -0.01%
==========================================
Files 264 264
Lines 67322 67321 -1
==========================================
- Hits 60729 60723 -6
- Misses 6593 6598 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
/botio browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/1554fc560ac1d0e/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/99bcfdffccd3cae/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/1554fc560ac1d0e/output.txt Total script time: 18.09 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/99bcfdffccd3cae/output.txt Total script time: 23.78 mins
|
The
Page.prototype.createAnnotationEvaluatormethod is just a simple wrapper around a private method, hence we can just expose that one directly to avoid a tiny bit of unnecessary code duplication.