Skip to content

Remove the "duplicated" Page.prototype.createAnnotationEvaluator method - #21817

Open
Snuffleupagus wants to merge 1 commit into
mozilla:masterfrom
Snuffleupagus:rm-Page-createAnnotationEvaluator
Open

Remove the "duplicated" Page.prototype.createAnnotationEvaluator method#21817
Snuffleupagus wants to merge 1 commit into
mozilla:masterfrom
Snuffleupagus:rm-Page-createAnnotationEvaluator

Conversation

@Snuffleupagus

Copy link
Copy Markdown
Collaborator

The Page.prototype.createAnnotationEvaluator method is just a simple wrapper around a private method, hence we can just expose that one directly to avoid a tiny bit of unnecessary code duplication.

…thod

The `Page.prototype.createAnnotationEvaluator` method is just a simple wrapper around a private method, hence we can just expose that one directly to avoid a tiny bit of unnecessary code duplication.
@Snuffleupagus
Snuffleupagus deployed to code-coverage August 24, 2026 08:52 — with GitHub Actions Active
@codecov-commenter

codecov-commenter commented Aug 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.19%. Comparing base (a570239) to head (0228461).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21817      +/-   ##
==========================================
- Coverage   90.20%   90.19%   -0.01%     
==========================================
  Files         264      264              
  Lines       67322    67321       -1     
==========================================
- Hits        60729    60723       -6     
- Misses       6593     6598       +5     
Flag Coverage Δ
browsertest 66.31% <83.33%> (+<0.01%) ⬆️
fonttest 8.91% <ø> (ø)
integrationtest 69.41% <66.66%> (-0.01%) ⬇️
unittest 58.37% <100.00%> (-0.01%) ⬇️
unittestcli 56.95% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Snuffleupagus

Copy link
Copy Markdown
Collaborator Author

/botio browsertest

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/1554fc560ac1d0e/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/99bcfdffccd3cae/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/1554fc560ac1d0e/output.txt

Total script time: 18.09 mins

  • Regression tests: Passed

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/99bcfdffccd3cae/output.txt

Total script time: 23.78 mins

  • Regression tests: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants