Re-use computeLuminance in the DOMFilterFactory.prototype.addHCMFilter method - #21813
Conversation
…lter` method When the `addHCMFilter` method was added the helper function didn't exist, but now we can utilize it to avoid a tiny bit of code duplication.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21813 +/- ##
==========================================
- Coverage 90.20% 90.19% -0.01%
==========================================
Files 264 264
Lines 67339 67337 -2
==========================================
- Hits 60741 60734 -7
- Misses 6598 6603 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
timvandermeij
left a comment
There was a problem hiding this comment.
r=me, with passing browser tests. Thank you!
|
/botio browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/00b0c33e4e1043b/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/bb759dcee6ff018/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/00b0c33e4e1043b/output.txt Total script time: 18.14 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/bb759dcee6ff018/output.txt Total script time: 23.23 mins
|
When the
addHCMFiltermethod was added the helper function didn't exist, but now we can utilize it to avoid a tiny bit of code duplication.