Skip to content

Re-use computeLuminance in the DOMFilterFactory.prototype.addHCMFilter method - #21813

Merged
Snuffleupagus merged 1 commit into
mozilla:masterfrom
Snuffleupagus:addHCMFilter-computeLuminance
Aug 23, 2026
Merged

Re-use computeLuminance in the DOMFilterFactory.prototype.addHCMFilter method#21813
Snuffleupagus merged 1 commit into
mozilla:masterfrom
Snuffleupagus:addHCMFilter-computeLuminance

Conversation

@Snuffleupagus

Copy link
Copy Markdown
Collaborator

When the addHCMFilter method was added the helper function didn't exist, but now we can utilize it to avoid a tiny bit of code duplication.

…lter` method

When the `addHCMFilter` method was added the helper function didn't exist, but now we can utilize it to avoid a tiny bit of code duplication.
@codecov-commenter

codecov-commenter commented Aug 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.19%. Comparing base (0f26334) to head (2c57dec).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21813      +/-   ##
==========================================
- Coverage   90.20%   90.19%   -0.01%     
==========================================
  Files         264      264              
  Lines       67339    67337       -2     
==========================================
- Hits        60741    60734       -7     
- Misses       6598     6603       +5     
Flag Coverage Δ
browsertest 66.29% <100.00%> (-0.05%) ⬇️
fonttest 8.91% <ø> (ø)
integrationtest 69.38% <100.00%> (-0.02%) ⬇️
unittest 58.36% <0.00%> (+<0.01%) ⬆️
unittestcli 56.93% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timvandermeij timvandermeij left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with passing browser tests. Thank you!

@Snuffleupagus

Copy link
Copy Markdown
Collaborator Author

/botio browsertest

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/00b0c33e4e1043b/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/bb759dcee6ff018/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/00b0c33e4e1043b/output.txt

Total script time: 18.14 mins

  • Regression tests: Passed

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/bb759dcee6ff018/output.txt

Total script time: 23.23 mins

  • Regression tests: Passed

@Snuffleupagus
Snuffleupagus merged commit a570239 into mozilla:master Aug 23, 2026
21 checks passed
@Snuffleupagus
Snuffleupagus deleted the addHCMFilter-computeLuminance branch August 23, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants