test(http3): trim the datagram burst test's doc comment - #4032
Merged
larseggert merged 1 commit intoSep 30, 2026
Merged
Conversation
Keep the why, drop the how. The mechanics of the check, that Overflowed does not name the evicted ids and that identity is therefore established by which payloads arrive, are readable from the test body and its inline comments.
mxinden
requested review from
KershawChang,
larseggert and
martinthomson
as code owners
September 30, 2026 15:54
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The comment remains accurate, and no code behavior changes.
Review effort: Balanced
Findings: None
What changed in this PR
This follow-up to #4003 trims a WebTransport test comment in response to feedback on #3985. It does not change test behavior.
Changes:
- Shortens the datagram burst test’s comment while retaining its priority-eviction intent.
| File | Description |
|---|---|
neqo-http3/src/features/extended_connect/tests/webtransport/datagrams.rs |
Trims the test’s doc comment. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
larseggert
approved these changes
Sep 30, 2026
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4032 +/- ##
==========================================
- Coverage 97.10% 96.91% -0.19%
==========================================
Files 114 119 +5
Lines 41005 41350 +345
Branches 41005 41350 +345
==========================================
+ Hits 39817 40075 +258
- Misses 1174 1251 +77
- Partials 14 24 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Contributor
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-pr as client
neqo-pr as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-pr as client
neqo-pr as server
|
Contributor
Client/server transfer resultsPerformance differences relative to 9e79b5f. Transfer of 33554432 bytes over loopback, min. 100 runs. All unit-less numbers are in milliseconds.
Table above only shows statistically significant changes. See all results below. All resultsTransfer of 33554432 bytes over loopback, min. 100 runs. All unit-less numbers are in milliseconds.
Download data for |
Contributor
Benchmark resultsNo significant performance differences relative to 9e79b5f. All resultstransfer/1-conn/1-100mb-req (aka. Upload)/mtu-1500 time: [50.456 ms 50.564 ms 50.708 ms]
thrpt: [1.9259 GiB/s 1.9314 GiB/s 1.9355 GiB/s]
Found 9 outliers among 100 measurements (9.00%)
4 (4.00%) low mild
2 (2.00%) high mild
3 (3.00%) high severetransfer/1-conn/1-100mb-resp (aka. Download)/mtu-1500 time: [49.704 ms 49.746 ms 49.789 ms]
thrpt: [1.9614 GiB/s 1.9631 GiB/s 1.9647 GiB/s]
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mildtransfer/1-conn/1-1b-resp (aka. HPS)/mtu-1500 time: [2.9811 ms 2.9829 ms 2.9848 ms]
thrpt: [335.03 B/s 335.24 B/s 335.45 B/s]transfer/1-conn/10_000-parallel-1b-resp (aka. RPS)/mtu-1500 time: [66.857 ms 67.144 ms 67.433 ms]
thrpt: [148.29 Kelem/s 148.93 Kelem/s 149.57 Kelem/s]streams-flow-controlled/walltime/1-streams/each-4194304-bytes time: [10.699 ms 10.702 ms 10.704 ms]
thrpt: [373.68 MiB/s 373.77 MiB/s 373.85 MiB/s]
Found 3 outliers among 100 measurements (3.00%)
3 (3.00%) high mildstreams-flow-controlled/walltime/10-streams/each-1048576-bytes time: [28.854 ms 28.865 ms 28.876 ms]
thrpt: [346.31 MiB/s 346.44 MiB/s 346.57 MiB/s]
Found 4 outliers among 100 measurements (4.00%)
2 (2.00%) low mild
2 (2.00%) high mildstreams/walltime/1-streams/each-1000-bytes time: [131.46 µs 132.01 µs 132.70 µs]
thrpt: [7.1865 MiB/s 7.2244 MiB/s 7.2544 MiB/s]
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mildstreams/walltime/1000-streams/each-1-bytes time: [3.8394 ms 3.8510 ms 3.8622 ms]
thrpt: [252.85 KiB/s 253.59 KiB/s 254.35 KiB/s]streams/walltime/1000-streams/each-1000-bytes time: [12.404 ms 12.415 ms 12.427 ms]
thrpt: [76.744 MiB/s 76.815 MiB/s 76.887 MiB/s]transfer/walltime/pacing-false/same-seed time: [2.0220 ms 2.0229 ms 2.0239 ms]
thrpt: [1.9300 GiB/s 1.9310 GiB/s 1.9319 GiB/s]
Found 3 outliers among 100 measurements (3.00%)
3 (3.00%) high mildtransfer/walltime/pacing-false/varying-seeds time: [2.0553 ms 2.0563 ms 2.0574 ms]
thrpt: [1.8986 GiB/s 1.8997 GiB/s 1.9005 GiB/s]transfer/walltime/pacing-true/same-seed time: [2.0940 ms 2.0964 ms 2.0992 ms]
thrpt: [1.8608 GiB/s 1.8633 GiB/s 1.8654 GiB/s]transfer/walltime/pacing-true/varying-seeds time: [2.0973 ms 2.0986 ms 2.1002 ms]
thrpt: [1.8599 GiB/s 1.8614 GiB/s 1.8625 GiB/s]Instructions per cycleCriterion reported no significant timing changes. All benchmarks
Profiles for profiler.firefox.com (62)
Download data for |
Contributor
Merging this PR will degrade performance by 3.57%
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4003.
Addresses #3985 (comment)