test: make process cleanup work on Windows - #165
Merged
juliandescottes merged 4 commits intoAug 25, 2026
Conversation
f3tchcodes
force-pushed
the
test/windows-process-cleanup
branch
from
August 22, 2026 17:50
2498f3e to
068e47f
Compare
juliandescottes
requested changes
Aug 25, 2026
Contributor
Author
|
All changes have been made! I also renamed the function |
Co-authored-by: Julian Descottes <jdescottes@mozilla.com>
f3tchcodes
force-pushed
the
test/windows-process-cleanup
branch
from
August 25, 2026 15:57
7d30325 to
4d491ff
Compare
f3tchcodes
force-pushed
the
test/windows-process-cleanup
branch
from
August 25, 2026 15:58
4d491ff to
4b1c8fe
Compare
juliandescottes
requested changes
Aug 25, 2026
juliandescottes
left a comment
juliandescottes
left a comment
Collaborator
There was a problem hiding this comment.
My bad, the findWindowsProcessIds was also used to find geckodriver processes, only the comment was confusing. We need to restore it and fix the comment
f3tchcodes
force-pushed
the
test/windows-process-cleanup
branch
from
August 25, 2026 16:16
4b1c8fe to
b56ecad
Compare
Contributor
Author
|
Restored! I completely missed it even after reading through the code haha. Thanks for catching it before the merge! |
juliandescottes
requested changes
Aug 25, 2026
juliandescottes
left a comment
juliandescottes
left a comment
Collaborator
There was a problem hiding this comment.
Just a comment to update and we should be good to go, thanks!
Co-authored-by: Julian Descottes <jdescottes@mozilla.com>
f3tchcodes
force-pushed
the
test/windows-process-cleanup
branch
from
August 25, 2026 17:47
9ad6c77 to
b13525b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the Vitest cleanup work properly on Windows.
The current cleanup uses Unix-only commands like
pgrep,pkill, andkill, so running the tests on Windows prints command errors even though the tests themselves still run.This change keeps the existing cleanup behavior for Linux and macOS, while adding a Windows-specific cleanup path. On Windows, it finds Firefox test instances using the
--marionettecommand-line argument, terminates those process trees withtaskkill, and cleans up leftovergeckodriver.exeprocesses without touching normal Firefox windows.