Skip to content

Clarify nominated status is not public tip in addon_details.html #25338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ubershmekel wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −3
Open

Clarify nominated status is not public tip in addon_details.html #25338

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/olympia/devhub/templates/devhub/includes/addon_details.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,9 @@
{% set status_tips = {
amo.STATUS_NULL: _('Please complete your add-on by adding a version or missing metadata.'),
amo.STATUS_NOMINATED: _("You will receive an email when the review is complete. Until "
"then, your add-on is not listed in our gallery but can be "
"accessed directly from its details page. "),
"then, this version is not publicly available."),

@diox diox Aug 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So technically, if you're logged in as an author, that detail page works, right ? So maybe it would be more accurate to keep the original string and just something about authenticated authors being able to access it.

@ubershmekel ubershmekel Aug 25, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I see what you mean so something like:

You will receive an email when the review is complete. Until then, your add-on is not publicly available but you, the authenticated author, can access its details page.

Is that what you meant?

@diox diox Aug 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that looks good. Technically other authors can see it too, if there are any, but I don't think we need to include that level of detail here.

amo.STATUS_APPROVED: _("Your add-on is displayed in our gallery and users are "
"receiving automatic updates."),
"receiving automatic updates."),
amo.STATUS_DISABLED: _("Your add-on was disabled by a site administrator and is no "
"longer shown in our gallery."),
amo.STATUS_REJECTED: _("Your add-on listing was rejected. It is not listed in our gallery. "
Expand Down