Repository navigation
Conversation
|
No new issues detected. This pull request is 🆗 |
pollym
force-pushed
the
fix-duplicate-classes-for-r8
branch
from
October 13, 2026 16:12
56a4c83 to
a15db60
Compare
|
No new issues detected. This pull request is 🆗 |
These break obfuscation and were not being used any more. They were previously used by SyncIntegrationTest, which is not currently run, so if this is ever restored we will have to figure out a minification-friendly way of doing this. some more details: - The androidTest copies break once the build is minified. R8 rewrites the app's version, so the test copy no longer matches it. - The test `AppRequestInterceptor` had drifted from the real one. It was missing about:home handling, the story UTM interceptor, interceptsAppInitiatedRequests and the content-URI telemetry. - the test version of AppRequestInterceptor had different behaviour to the app one. The app one overrode interceptsAppInitiatedRequests to set it to true and the test one didn't, so it defaulted to false. This means that using the app one, you get a "Open this link in xxx app?" dialog which the tests didn't previously expect. I've fixed this by dismissing the dialog in MainMenuTest.
pollym
force-pushed
the
fix-duplicate-classes-for-r8
branch
from
October 14, 2026 10:55
a15db60 to
de23193
Compare
segunfamisa
approved these changes
Oct 14, 2026
segunfamisa
left a comment
segunfamisa
left a comment
Contributor
There was a problem hiding this comment.
We reviewed-and-brewed this patch, and we think it's a-oh-kay.
There was a suggestion from @t-p-white to add some comments & screenshots about this.
We were first concerned if we had to contribute the "stay in" to the "efficiency tests", but those already pass on the try, so this is okay.
Thanks Polly.
lando-worker Bot
pushed a commit
that referenced
this pull request
Oct 14, 2026
These break obfuscation and were not being used any more. `FxaServer` was previously used by `SyncIntegrationTest`, which is not currently run, so if this is ever restored we will have to figure out a minification-friendly way of doing this. (I've chatted to mobile test about this) some more details: - The `androidTest` copies break once the build is minified. R8 rewrites the app's version, so the test copy no longer matches it. - The test `AppRequestInterceptor` had drifted from the real one. It was missing about:home handling, the story UTM interceptor, interceptsAppInitiatedRequests and the content-URI telemetry. - also, the test version of `AppRequestInterceptor` had different behaviour to the app one. The app one overrode `interceptsAppInitiatedRequests` to set it to true and the test one didn't, so it defaulted to false. This means that using the app one, you get a "Open this link in xxx app?" dialog which the tests didn't previously expect. <img width="304" height="550" alt="example of the app links dialog" src="https://github.com/user-attachments/assets/cac27662-9c72-4e37-9ffe-13916cf9a1b5" /> I've fixed this by dismissing the dialog in `MainMenuTest`. [try is running here](https://treeherder.mozilla.org/jobs?repo=try&landoInstance=lando-prod-2025&landoCommitID=104609) Pull request: #388
|
Pull request closed by commit 92f9de0 |
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 15, 2026
These break obfuscation and were not being used any more. `FxaServer` was previously used by `SyncIntegrationTest`, which is not currently run, so if this is ever restored we will have to figure out a minification-friendly way of doing this. (I've chatted to mobile test about this) some more details: - The `androidTest` copies break once the build is minified. R8 rewrites the app's version, so the test copy no longer matches it. - The test `AppRequestInterceptor` had drifted from the real one. It was missing about:home handling, the story UTM interceptor, interceptsAppInitiatedRequests and the content-URI telemetry. - also, the test version of `AppRequestInterceptor` had different behaviour to the app one. The app one overrode `interceptsAppInitiatedRequests` to set it to true and the test one didn't, so it defaulted to false. This means that using the app one, you get a "Open this link in xxx app?" dialog which the tests didn't previously expect. <img width="304" height="550" alt="example of the app links dialog" src="https://github.com/user-attachments/assets/cac27662-9c72-4e37-9ffe-13916cf9a1b5" /> I've fixed this by dismissing the dialog in `MainMenuTest`. [try is running here](https://treeherder.mozilla.org/jobs?repo=try&landoInstance=lando-prod-2025&landoCommitID=104609) Pull request: mozilla-firefox/firefox#388 UltraBlame original commit: 7ad1ced2b9ac8565f04adc22084169614f92c9c0
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 15, 2026
These break obfuscation and were not being used any more. `FxaServer` was previously used by `SyncIntegrationTest`, which is not currently run, so if this is ever restored we will have to figure out a minification-friendly way of doing this. (I've chatted to mobile test about this) some more details: - The `androidTest` copies break once the build is minified. R8 rewrites the app's version, so the test copy no longer matches it. - The test `AppRequestInterceptor` had drifted from the real one. It was missing about:home handling, the story UTM interceptor, interceptsAppInitiatedRequests and the content-URI telemetry. - also, the test version of `AppRequestInterceptor` had different behaviour to the app one. The app one overrode `interceptsAppInitiatedRequests` to set it to true and the test one didn't, so it defaulted to false. This means that using the app one, you get a "Open this link in xxx app?" dialog which the tests didn't previously expect. <img width="304" height="550" alt="example of the app links dialog" src="https://github.com/user-attachments/assets/cac27662-9c72-4e37-9ffe-13916cf9a1b5" /> I've fixed this by dismissing the dialog in `MainMenuTest`. [try is running here](https://treeherder.mozilla.org/jobs?repo=try&landoInstance=lando-prod-2025&landoCommitID=104609) Pull request: mozilla-firefox/firefox#388 UltraBlame original commit: 7ad1ced2b9ac8565f04adc22084169614f92c9c0
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 15, 2026
These break obfuscation and were not being used any more. `FxaServer` was previously used by `SyncIntegrationTest`, which is not currently run, so if this is ever restored we will have to figure out a minification-friendly way of doing this. (I've chatted to mobile test about this) some more details: - The `androidTest` copies break once the build is minified. R8 rewrites the app's version, so the test copy no longer matches it. - The test `AppRequestInterceptor` had drifted from the real one. It was missing about:home handling, the story UTM interceptor, interceptsAppInitiatedRequests and the content-URI telemetry. - also, the test version of `AppRequestInterceptor` had different behaviour to the app one. The app one overrode `interceptsAppInitiatedRequests` to set it to true and the test one didn't, so it defaulted to false. This means that using the app one, you get a "Open this link in xxx app?" dialog which the tests didn't previously expect. <img width="304" height="550" alt="example of the app links dialog" src="https://github.com/user-attachments/assets/cac27662-9c72-4e37-9ffe-13916cf9a1b5" /> I've fixed this by dismissing the dialog in `MainMenuTest`. [try is running here](https://treeherder.mozilla.org/jobs?repo=try&landoInstance=lando-prod-2025&landoCommitID=104609) Pull request: mozilla-firefox/firefox#388 UltraBlame original commit: 7ad1ced2b9ac8565f04adc22084169614f92c9c0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These break obfuscation and were not being used any more.
FxaServerwas previously used bySyncIntegrationTest, which is not currently run, so if this is ever restored we will have to figure out a minification-friendly way of doing this. (I've chatted to mobile test about this)some more details:
androidTestcopies break once the build is minified. R8 rewrites the app's version, so the test copy no longer matches it.AppRequestInterceptorhad drifted from the real one. It was missing about:home handling, the story UTM interceptor, interceptsAppInitiatedRequests and the content-URI telemetry.AppRequestInterceptorhad different behaviour to the app one. The app one overrodeinterceptsAppInitiatedRequeststo set it to true and the test one didn't, so it defaulted to false. This means that using the app one, you get a "Open this link in xxx app?" dialog which the tests didn't previously expect.I've fixed this by dismissing the dialog in
MainMenuTest.try is running here
Lando: link
Bugzilla: bug 2071822
🚫 This pull request has 2 blockers.