Repository navigation
Add dice provider to the urlbar - #386
Closed
masudataiki wants to merge 1 commit into
Closed
masudataiki wants to merge 1 commit into
masudataiki wants to merge 1 commit into
Conversation
No Taskcluster jobs started for this pull requestThe |
Contributor
|
(Automated Close) Please do not file pull requests here, see https://firefox-source-docs.mozilla.org/contributing/how_to_submit_a_patch.html |
|
Warning The following requested teams have no members: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
アドレスバーに
diceと入力すると、候補一覧にサイコロの目(1〜6)を表示する機能を追加しました。既存の電卓機能(UrlbarProviderCalculator)を手本にした、新しい「即答」プロバイダです。
変更したファイル
browser/components/urlbar/UrlbarProviderDice.sys.mjsbrowser/components/urlbar/UrlbarProvidersManager.sys.mjsUrlbarProviderDiceを登録browser/components/urlbar/moz.build動作確認の手順
前提
./mach buildが通ること)1. ブランチを取得する
2. ビルドして起動する
新しいファイルを
moz.buildに追加したため、./mach build fasterではなく通常のビルドが必要です。-purgecachesは、古いスクリプトのキャッシュを使わないようにするためのオプションです。3. 確認する項目
diceと入力するdiceと入力するDiceやDICEと入力するdicやdice2と入力する2+3と入力するうまく動かないとき
確認してくれた人へ
確認が済んだら、項目の番号ごとに OK / NG をこの PR にコメントしてもらえると助かります。
Lando: link
🚫 This pull request has 2 blockers.