Repository navigation
Conversation
The regular expressions introduced in moxystudio#160 to avoid backtracking match a single backslash, so only one backslash of a run before a double quote or at the end of an argument was doubled. Match whole runs in a single pass instead, which keeps the escaping linear. Fixes moxystudio#188 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #188.
The regular expressions added in #160 to avoid backtracking match a single backslash (
\\+?is lazy), so only one backslash of a run before"or at the end of an argument gets doubled. Arguments passed to a.cmd/.batcan then split or swallow their neighbours:Making the quantifier greedy fixes the output but brings back the quadratic case from #160 (~30 s for 160 KB of backslashes on my machine). This PR replaces both expressions with a single pass that matches each run of backslashes as a whole, so it stays linear (~1 ms for the same input).
Testing:
doubleEscapeMetaChars).lib/util/escape.test.js(backslash runs before"and at the end, a linear-time check) and a Windows end-to-end test through the.cmdshim. 6 tests fail without the change;npm testpasses with it (92 tests, Windows 11, Node 24), and lint passes.This change was prepared with AI assistance. I reviewed it and ran the checks above myself.
🤖 Generated with Claude Code