Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds unit tests for the two previously untested utilities in
lib/util:escape.test.js- coversescape.command/escape.argument: meta-char caret escaping, quoting, backslash runs before quotes and at the end of the argument, non-string input, and thedoubleEscapeMetaCharsoption. The backslash-run cases assert the current implementation's behavior (deliberately altered in fix: disable regexp backtracking #160 to avoid regex backtracking) as regression coverage.resolveCommand.test.js- covers resolution from the ambientPATH, nonexistent commands, a customenvPATH, and custom-cwdswitching/restoring, using temp-dir fixtures.Coverage for
lib/utilgoes from ~43% lines (escape 23%, resolveCommand 21%) to 100%.Test plan
npx jest --env node: 81 passed, 6 failed - the 6 failures (should emit error/close ... non-existing cwd/command,should fail with ENOENT ...) fail identically on a clean checkout in this environment: the sandbox surfacesEACCESinstead ofENOENTfor missing commands. All 13 new tests pass.npx eslint lib/util/escape.test.js lib/util/resolveCommand.test.js: clean.