Repository navigation
chore: replace appveyor with github workflows windows runners - #185
Merged
Merged
Conversation
wmic is no longer installed by default on Windows Server 2025 and Windows 11 24H2, which made the "should NOT spawn a shell for a .exe" test fail. process.ppid is available since Node.js 9.2.
Run the unit tests on both ubuntu-latest and windows-latest, run lint once, and also run CI on pull requests.
satazor
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves Windows CI from AppVeyor to GitHub Actions, so all CI runs in one place.
ubuntu-latestandwindows-latestwith Node.js 18, 20 and 22.pull_requesttoo, so pull requests from forks get checked.appveyor.ymland the AppVeyor badge.The
win-ppid.jsfixture usedwmicto find its parent process.wmicis no longer installed by default on Windows Server 2025 (whichwindows-latestuses) and Windows 11 24H2, so the "should NOT spawn a shell for a .exe" test failed. The fixture now printsprocess.ppidinstead, which Node.js has had since 9.2.The test still catches a shell in between: spawning the fixture directly reports the test process as its parent, while forcing
cmd.exereports thecmd.exeprocess.