Skip to content

fix(runtime): validate max loop limit #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ralyodio merged 1 commit into from
Jul 30, 2026
Merged

fix(runtime): validate max loop limit #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/runtime.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,9 @@ export async function runScript(source, opts = {}) {
}
const out = opts.out || ((s) => console.log(s));
const max = Number.isFinite(opts.max) ? opts.max : DEFAULT_MAX;
if (!Number.isInteger(max) || max < 1) {
throw new Error(`moshscript: max must be a positive integer, got ${JSON.stringify(opts.max)}`);
}
const control = makeControl(max, out);

const ctx = {
Expand Down
13 changes: 13 additions & 0 deletions test/runtime.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,19 @@ test("DEFAULT_MAX bounds an unbounded while when no max is passed", async () =>
assert.equal(calls.length, DEFAULT_MAX);
});

test("runScript rejects invalid max values", async () => {
const { registry } = recorder();

await assert.rejects(
() => runScript(`while (alive) {}`, { commands: registry, max: 0 }),
/max must be a positive integer/,
);
await assert.rejects(
() => runScript(`while (alive) {}`, { commands: registry, max: 1.5 }),
/max must be a positive integer/,
);
});

test("a rejecting fire-and-forget verb does not kill a script that keeps running", async () => {
const calls = [];
const registry = createRegistry([
Expand Down
Loading