Skip to content

Validate moshscript sleep durations #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ralyodio merged 1 commit into from
Jul 12, 2026
Merged

Validate moshscript sleep durations #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/commands.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,11 @@ export function defaultCommands() {
// handy extras
say: (ctx, args) => ctx.out(` 💬 ${args.join(" ")}`),
sleep: async (_ctx, args) => {
const ms = Number(args[0] || 0);
const raw = args[0] ?? 0;
const ms = Number(raw);
if (!Number.isFinite(ms) || ms < 0) {
throw new Error(`moshscript: sleep(ms) requires a finite non-negative number, got ${JSON.stringify(raw)}`);
}
if (ms > 0) await new Promise((r) => setTimeout(r, ms));
},
stop: (ctx, args) => {
Expand Down
12 changes: 12 additions & 0 deletions test/commands.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,15 @@ test("notify() still accepts message arguments", async () => {
assert.equal(ctx.lines.length, 1);
assert.match(ctx.lines[0], /hello there/);
});

test("sleep accepts zero milliseconds", async () => {
await defaultCommands().sleep({}, [0]);
});

test("sleep rejects non-finite and negative durations", async () => {
const sleep = defaultCommands().sleep;

await assert.rejects(() => sleep({}, ["forever"]), /finite non-negative number/);
await assert.rejects(() => sleep({}, ["Infinity"]), /finite non-negative number/);
await assert.rejects(() => sleep({}, [-1]), /finite non-negative number/);
});
Loading