Skip to content

Fix skillName test below uppercase directories #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ralyodio merged 1 commit into from
Jul 28, 2026
Merged

Fix skillName test below uppercase directories #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions test/skills.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,11 @@ test("skillName derives from a git url or path, or takes an override", () => {
});

test("skillName never yields `.` or `..`, which would escape the skills dir", () => {
const here = path.basename(process.cwd());
const parent = path.basename(path.dirname(process.cwd()));
// skillName normalizes every derived name to lowercase, including the
// cwd-based fallback. Keep this portable when a checkout lives below an
// uppercase directory such as ~/Projects.
const here = path.basename(process.cwd()).toLowerCase();
const parent = path.basename(path.dirname(process.cwd())).toLowerCase();
assert.equal(skillName("."), here);
assert.equal(skillName("./"), here);
assert.equal(skillName("a/b/."), "b");
Expand Down
Loading