Skip to content

pit: a parked name is a page, not a 404 #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ralyodio merged 1 commit into from
Jul 31, 2026
Merged

pit: a parked name is a page, not a 404 #149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion apps/pwa/src/routes/moshpit.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,12 @@ moshpitRouter.get("/n/:name", async (req, res) => {
? await quoteName({ tld, label: parsed.label, buyerId: req.user.id })
: null;

res.status(resolution.name_registered ? 200 : 404).send(page({
// 200, not 404, even when nobody holds the name. The URL does have a
// resource — this directory is the parking page every resolver and the
// browser extension send unpointed names to, and it is the answer, not the
// absence of one. A 404 makes a working page read as broken to the browser,
// to a link checker, and to anything that treats the status before the body.
res.status(200).send(page({
title: resolution.name,
body: directory({ resolution, tld, owner, names, tlds, quote, user: req.user, req }),
}));
Expand Down
Loading