feat: add NewL2BlockV2 support in executor + RetryableClient#934
Open
tomatoishealthy wants to merge 2 commits intofeat/sequencer-ha-v2from
Open
feat: add NewL2BlockV2 support in executor + RetryableClient#934tomatoishealthy wants to merge 2 commits intofeat/sequencer-ha-v2from
tomatoishealthy wants to merge 2 commits intofeat/sequencer-ha-v2from
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
tomatoishealthy
force-pushed
the
feat/reorg-geth
branch
from
6c595d3 to
db05508
Compare
tomatoishealthy
force-pushed
the
feat/sequencer-ha-v2
branch
from
189d543 to
0c72713
Compare
tomatoishealthy
force-pushed
the
feat/reorg-geth
branch
from
db05508 to
1c80916
Compare
Wire up the new engine_newL2BlockV2 API for reorg support: - Executor.ApplyBlockV2 now returns (applied bool, err error) matching the updated L2Node interface; detects idempotent skips and reorgs using BlockNumber + BlockByNumber checks before calling NewL2BlockV2 - RetryableClient.NewL2BlockV2 wraps the new authclient method with exponential backoff retry; excludes WrongBlockNumberError and ParentNotFoundError from retry (permanent errors) - RetryableClient.AssembleL2BlockV2 added for parent-hash-based block assembly Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
tomatoishealthy
force-pushed
the
feat/sequencer-ha-v2
branch
from
0c72713 to
c8a0bd5
Compare
tomatoishealthy
force-pushed
the
feat/reorg-geth
branch
from
1c80916 to
361e5a1
Compare
Add BlockHashMismatchError and InvalidNextL1MsgIndexError to the retryableError() exclusion list so the executor stops re-sending invalid payloads back to geth. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Executor.ApplyBlockV2returns(applied bool, err error)to let callers distinguish real applies from idempotent skips, preventingStateV2.latestBlockregression during HA Raft log replayRetryableClient.NewL2BlockV2wraps the newengine_newL2BlockV2RPC with retry, excludingWrongBlockNumberError/ParentNotFoundErrorfrom retryRetryableClient.AssembleL2BlockV2added for parent-hash-based block assemblyTest plan
go build ./node/...— compiles cleanlyUPGRADE_HEIGHT=10 ./run-test.sh test— full devnet test passed (PBFT → Sequencer → fullnode sync)🤖 Generated with Claude Code