fix(github): preserve full review comment IDs - #298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GitHub marks
PullRequestReviewComment.databaseIdas deprecated in favor of the BigInt-backedfullDatabaseId. The feedback synchronizer queried the deprecated field for review-thread comments and converted the returned ID toint64, which would both fail when GitHub removes the field and lose identifiers outside the signed 64-bit range.This change queries
fullDatabaseIdin both review-thread paths and carries comment and reply identifiers as strings through the feedback adapter and projection. Existing raw observations containing numeric IDs remain readable.Testing
make verifypassesint64and checks both GraphQL queries avoid deprecated comment fieldsmake test-racepasses (not needed; this change does not alter storage concurrency, locking, or cancellation)Compatibility and scope
No public API shape changes: persisted feedback IDs were already normalized as strings.