Fix incorrect path reformatting issue#488
Open
Heunsig wants to merge 1 commit into
Open
Conversation
|
Can we please get this merged? |
Author
Looks like the main contributor hasn't had a chance to review this yet |
pmhofman-se
approved these changes
Oct 30, 2024
pmhofman-se
left a comment
pmhofman-se
left a comment
There was a problem hiding this comment.
I'm ok with this. I am using this implementation already.
|
Has this repo been abandonned when Edgio took over Moov?? |
|
@BenKnigge, are you still maintaining this project? |
|
@BenKnigge can this be mergedd pretty please? This is a fatal bug rendering GVM useless when triggered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have fixed an issue in the
__gvm_munge_path()function located in the~/.gvm/scripts/function/munge_pathfile. Previously, paths containing spaces were being incorrectly parsed, leading to problems such as/AppData/Local/Programs/Microsoft:VS:Code/bin:/snap/bin, where colons (:) were inserted into the path names.Because of this, after installing
gvm, some terminal commands would result in a "command not found" error.To resolve this, I updated the script to enclose each path in double quotes (
"") when adding them to the array. This ensures paths with spaces are handled correctly.This fix should solve the following issues: #486 (comment), #487 (comment), #466 (comment)