Repository navigation
Conversation
caseyclements
left a comment
caseyclements
left a comment
There was a problem hiding this comment.
We need to have integration tests run. This should be added to MongoDB's ai-ml-pipeline-testing CI project.
| "types": "./dist/index.d.mts", | ||
| "default": "./dist/index.js" | ||
| }, | ||
| "require": { | ||
| "types": "./dist/index.d.cts", | ||
| "types": "./dist/index.d.ts", |
There was a problem hiding this comment.
Great catch. This fixes a real bug on main, as there's no top-level "type" field. Not caused by this PR, but worth fixing in a follow-up: ./dist/index.js contains ESM code, and the package has no "type": "module", so Node treats .js files as CommonJS. Node falls back to re-parsing it as ESM and prints a "Masquerading as ESM" warning.
There was a problem hiding this comment.
Thanks. Agreed that adding "type": "module" (or renaming the ESM output to .mjs) should be a follow-up, since it changes how every .js file resolves and needs its own compatibility check.
|
@caseyclements On it :) |
…icExists, CI integration tests
|
@caseyclements Fixes done |
|
@Pash10g - Were you able to run the integration tests against a running mongodb? |
|
@caseyclements Better! I have placed a whole CI with an Atlas container: https://github.com/mongodb-developer/vercel-ai-memory/actions/runs/37600975386 However , I am fixing a blocker I found with AI sdk 7: A real issue: v7 replaced experimental_context with runtimeContext, breaking your package's "context mode" hook (which still reads event.experimental_context at src/session-hooks.ts:152), so it silently saves no transcript. The alternative "closure mode" hook works fine on v7 but requires building the agent per-request. |
| @@ -0,0 +1,43 @@ | |||
| # `ai-ml-pipeline-testing` integration | |||
|
|
|||
| Files for MongoDB's [`ai-ml-pipeline-testing`](https://github.com/mongodb-labs/ai-ml-pipeline-testing) | |||
There was a problem hiding this comment.
Did you get this working? If so, awesome. Could you please send a link to a passing evergreen build?
We'll need to organize a time to demonstrate the ai-ml-pipeline-testing project, and after anyone can add their new work to it so that they can run integration tests with secrets, keys, access to the needed tools that github doesn't provide.
There was a problem hiding this comment.
evergreen? I am not familiar on how this works. There is a CI in the github ... Can you help looking if anything was added to evergreen..
There was a problem hiding this comment.
Since there is a blocking bug covered in this release maybe we can leave evergreen to a later point?
2 participants
Summary
Validation
Merging triggers the existing v0.6.0 tag and npm publishing workflow.