Repository navigation
fix(runtime): preserve selected credentials on resume (#1294 follow-up) - #1303
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A subscription Claude run still lost
CLAUDE_CODE_OAUTH_TOKENon ordinary resume when the operator redundantly included it inULTRAFUZZ_AGENT_ENV_ALLOWLIST. The resume scrubber now retains credentials consumed by the run's selected adapters while still removing unrelated sensitive allowlisted values.Follow-up to #1294. The regression covers token rotation and removal on resume, and the generated-adapter test checks subscription/API-key isolation. Its provider home now lives directly under the private temporary project, so the test also passes with
umask 002.Validation: the resume regression failed before the fix and passes afterward; the existing legacy-controller credential-stripping regression passes; the Bun adapter test passes with
umask 002; runtime dependency build, test compilation, strict ESLint, and formatting pass.

Confidence Score: 5/5
This PR appears safe to merge.Summary
Ordinary resume now keeps credentials required by the run’s selected adapters, even when those credentials also appear in
ULTRAFUZZ_AGENT_ENV_ALLOWLIST.Diagram
%%{init: {'theme': 'neutral'}}%% flowchart TD A[Current resume environment] --> B[Read selected adapters from saved run] B --> C[Keep selected credentials] C --> D[Remove unrelated sensitive allowlisted values] D --> E[Resume controller] E --> F[Blank provider credentials in child environment] F --> G[Add only the owning adapter's credentials]Reviews (1) · Last reviewed commit: "fix(runtime): retain selected provider c..." · Reviewed by Greptile