Repository navigation
perf(evm): apply the release profile from the workspace root - #59
Merged
Merged
Conversation
Cargo ignores [profile.*] in workspace members, so lto = "thin" and codegen-units = 1 stopped applying when the root workspace was added. Move them to the root Cargo.toml. typewriter-evm execute benchmark: erc20 transfer 18.8us -> 15.2us, counter 8.9us -> 7.9us.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cargo ignores
[profile.*]in workspace members. When the root workspace was added (ed2541e),lto = "thin"andcodegen-units = 1stopped applying to the native addon, andcargoprinted a warning on every lint run. This PR moves the profile to the rootCargo.toml.Results
typewriter-evmexecute benchmark: erc20 transfer 18.8 µs → 15.2 µs, counter 8.9 µs → 7.9 µs. The release build time does not change (~28 s).Test plan
bun run lint(the "profiles for the non root package will be ignored" warning is gone),bun run typecheck,bun run test🤖 Generated with Claude Code
This PR appears safe to merge.Summary
Moves
lto = "thin"andcodegen-units = 1to the workspace root so Cargo applies them to release builds.Reviews (1) · Last reviewed commit: "perf(evm): apply the release profile fro..." · Reviewed by Greptile