Skip to content

remove svg path from json file and icons with svg images #1

Description

@moghya

replace svg paths in js/profile.json with svg images of them at devicon and make appropriate changes in js/index.js

thanks for showing interest in this project.

In this template all of the data is loaded from a json file i.e profile.json
during development for skills icon I added svg paths and using them displayed the icons.
these paths were taken from devicon.
Code for loading content is in index.js please take a look at it

the svg paths make profile.json file cluttered. It would be great if svg images are stored of corresponding icons instead of the paths in json.

"skills": [
		{
			"sn": 1,
			"name": "C++",
			"icon": "M117.5 33.5l.3-.2c-.6-1.1-1.5-2.1-2.4-2.6l-48.3-27.8c-.8-.5-1.9-.7-3.1-.7-1.2 0-2.3.3-3.1.7l-48 27.9c-1.7 1-2.9 3.5-2.9 5.4v55.7c0 1.1.2 2.3.9 3.4l-.2.1c.5.8 1.2 1.5 1.9 1.9l48.2 27.9c.8.5 1.9.7 3.1.7 1.2 0 2.3-.3 3.1-.7l48-27.9c1.7-1 2.9-3.5 2.9-5.4v-55.8c.1-.8 0-1.7-.4-2.6zm-35.5 32.5v-4h5v-5h5v5h5v4h-5v5h-5v-5h-5zm3.3-14c-4.2-7.5-12.2-12.5-21.3-12.5-13.5 0-24.5 11-24.5 24.5s11 24.5 24.5 24.5c9.1 0 17.1-5 21.3-12.4l12.9 7.6c-6.8 11.8-19.6 19.8-34.2 19.8-21.8 0-39.5-17.7-39.5-39.5s17.7-39.5 39.5-39.5c14.7 0 27.5 8.1 34.3 20l-13 7.5zm29.7 14h-5v5h-4v-5h-6v-4h6v-5h4v5h5v4z"
		},
]

this will be changed to this

"skills": [
		{
			"sn": 1,
			"name": "C++",
			"icon": "cpp.svg"
		},

and accordingly changes should be done in index.js file.

Let me know if you can work on this :)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions