Conversation
Core decodes the stream commands, events, slices and consumed ranges only when its vendored api carries them. The type maps in the protos crate name the two new commands and events, which are not ignorable.
A consumed stream range reaches lang as its own job. The Rust SDKs have no stream API yet, so they fail the activation rather than drop records the server will not send again.
A workflow consumes and produces stream records through bridge commands 31 and 32. Each machine holds a reissued command to its recorded event on replay, and an unnamed append learns its stream name from the first event the server records.
The cases cover each command reaching the server, its round trip through replay, and which reissues replay refuses and which it accepts.
The poll response carries the records for the task about to run and re-supplies what earlier tasks consumed, keyed by the completion that recorded each range. Core hands them over in a fixed order, gives a consuming task its own activation on replay, and fails a task whose recorded range arrived without its records.
The cases cover live delivery, replay across history pages, the lookahead to the closing completion, missing and mismatched records, and notifications ordered ahead of a stream range.
The command and history protos import `stream/v1` from here on, so protoc reaches the envelope through them, as it does on the main lineage.
This was referenced Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replays the native stream commits onto the unified Core, so one Core speaks both stream prototypes.
What changed?
DeliverStreamRecordsjob, the two command machines and their tests, delivery and replay re-supply with their tests, and the changelog entries. Review the stream content on those PRs. This PR is where the two lineages meet.deliver_stream_recordsat 22,subscribe_streamat 31 andappend_stream_recordsat 32, after the channel's 21, 29 and 30.workflow_stream_channelsstays at 33.core_tests/channels.rs, which this lineage doesn't have, so it stays there.stream/v1from here on, so protoc reaches it through them, as on the main lineage.Part of AI-198 (epic AI-37).
Why?
One Core that speaks both prototypes lets one Python build run every provider. Replaying the commits keeps the native series out of a second merge, since its branch shares upstream as a base with this one. The vendored api here matches the main lineage's byte for byte, so both lineages put the same numbers on the wire.
How did you test it?
Link to a test plan if any -
The whole workspace lib suite passes at the head, and so does the coverage reporter run with the ignored tests.
cargo fmt --check,cargo lint,cargo test-lintand the CIcargo doccheck are clean, and each commit builds. The tree was compared with the earlier all-in-one branch. The stream files match it byte for byte, and the rest differs only by the renumber and the channel files aligned with the main lineage.