Conversation
A wake now notifies the stream's channel and steps down to the reserved Signal on a server without channels. The run reports the channels its open readers listen on with every completion, so Core keeps the server's subscriptions in step, and two lang flags record what the server offered for replay.
The unit cases cover the transports, the step-down memory, the three-way probe, the report and the flags. The live cases wake a reader through the independent and the linked channel against a server named with -E.
This was referenced Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes notification channels the external stream runtime's wake transport, with the reserved Signal as the fallback.
What changed?
_wake.pygainsWakeTransport(auto,channel,signal),channel_for,send_wake, the three-way server probe,WakeRequest.channelandchannel_execution, and a per-client memory that steps down to the Signal after the server answersUNIMPLEMENTED.ChannelAddresscomes fromtemporalio.client, so there's one copy.send_wakewith a position and a counter from the backend's order. Backends getwake_transport,wake_counter_forandwake_counter_now.subscribe_stream_channel. From then on every completion carries aWorkflowStreamChannelsreport of the open readers' channels, and Core subscribes and unsubscribes from it.test_wake.py,test_channel_report.py, the flag cases intest_channels.py, two live wake cases, and Signal pins in the cases that count Signals.Part of AI-198 (epic AI-37).
Why?
A reader parked on an external stream needs a wake when someone appends. The reserved Signal costs a History event per wake, and it only reaches a run that's already parked. A channel notification rides the scheduled event of the task it causes, folds repeats by counter, and reaches whatever run is current. Lang flags keep the choice deterministic, so a History written on a channel server replays on any Worker. The subscribe goes out in a report rather than as a command because a completion carrying a server-bound command can't be retained, and the task that opens a reader is exactly the one that should stay open and park.
How did you test it?
Link to a test plan if any -
poe lintis clean, and the external stream suite passes on the dev server at each commit. Against a channel server, the channel, report, wake and integration cases pass. The live wake through the linked channel passed with the linked kind on. The wake through the independent channel passed with it off.