Skip to content

Pinned Core at the external-stream repairs. - #38

Open
moedash wants to merge 1 commit into
moe/AI-198-if-pyext-1-toolingfrom
moe/AI-198-if-pyext-2-core-repairs-pin
Open

moedash wants to merge 1 commit into
moe/AI-198-if-pyext-1-toolingfrom
moe/AI-198-if-pyext-2-core-repairs-pin

Conversation

@moedash

@moedash moedash commented Oct 3, 2026

Copy link
Copy Markdown
Owner

This PR pins the external-streams Core that carries the external stream repairs.

What changed?

  • temporalio/bridge/sdk-core points at the repaired Core, and .gitmodules names its branch.
  • poe gen-protos adds temporalio/api/stream/v1 with StreamRecord and StreamRecordKind. The pin forces it, and nothing reads it until the interface mirror PR.
  • Three ### Fixed changelog lines for the Core fixes this pin brings.

Part of AI-198 (epic AI-37).

Why?

The Core fixes live entirely in Rust, so Python gets them by moving the pin. With caching off, Core now keeps a retained external-stream task until its boundary. Wakes met during replay resume the waits they belong to. A stale wait no longer forces an output replacement task. The record envelope comes with the same Core, because the external Core vendors it right under these fixes. The old branch layered the api diff with scripts/gen_stream_api_protos.py. That isn't needed here, since plain poe gen-protos reads what Core vendors.

How did you test it?

Link to a test plan if any -

  • Unit Tests
  • Staging
  • End to End Tests

The bridge builds and poe lint is clean. The Nexus system generator runs on this pin and gives back the committed output. The external stream suite, the worker workflow, visitor and client suites pass on the dev server. The channel cases pass with -E against a channel server.

This Core resumes reconstructed waits on wakes met during replay, stops stale
waits from forcing an output task, and keeps a retained task with caching off.
It also vendors the stream record envelope, which plain gen-protos now writes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant