Conversation
These cases measure real-server timing, which the time-skipping server takes away, so which of them fail there drifts run to run. Offline cases still run on both environments.
pydoctor resolves single-backtick prose as symbol references, so shell words, tuples and file names were read as missing targets. Two tables also lost their column alignment because pydoctor rewrites role references before parsing.
This was referenced Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two pieces of tooling on the external-streams branch: the time-skipping test run and the docs build.
What changed?
conftest.pyskips the server-backed cases when the suite runs on the time-skipping server. Offline cases still run there.contrib/external_workflow_streamsandworker/_workflow.pyuse double backticks for literal text, and the two error tables are realigned.Part of AI-198 (epic AI-37).
Why?
The server-backed cases measure real-server timing: how long a task was held open, how often a wake sweep runs, how long a shutdown waits. The time-skipping server advances the clock whenever workers go idle, so those cases fail there, and which ones fail changes from run to run. The dev-server step still runs all of them. pydoctor reads single backticks as symbol references, so it failed on shell words, tuples and file names, and it broke the two tables.
How did you test it?
Link to a test plan if any -
Before the change, a handoff case timed out on the time-skipping server. After it, the suite is green there with the server-backed cases skipped, and it's green in full on the dev server. pydoctor exited with errors on this package before and runs clean after.
poe lintis clean.