Conversation
The channel protos, the NotificationsReceived job and the subscribe and unsubscribe commands come from this Core, so the Python protos, the payload visitor and the client RPC bindings are regenerated from it with plain gen-protos.
This was referenced Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR pins the external-streams Core that carries notification channels and regenerates the Python protos from it.
What changed?
temporalio/bridge/sdk-corepoints at the channel Core built on this branch's own Core base..gitmodulesnow namesmoedash/sdk-rust, since the old URL doesn't have the commit.poe gen-protoswrites from that pin: thenotification/v1package, the channel commands, events and failed causes,ChannelSubscriptionInfo, the five channel RPCs and their messages, theNotificationsReceivedjob and the two channel commands in the bridge protos. The pin forces the_visitor.py,services_generated.pyandclient_rpc_generated.rschanges too.Part of AI-198 (epic AI-37).
Why?
The channel surface in the next PR needs these types and RPCs. Keeping the pin on its own means that PR shows only hand-written code. The old external branch layered the api diff over the vendored protos with
scripts/gen_stream_api_protos.py. That script isn't coming back, because this Core vendors the channel api itself and plainpoe gen-protoscovers it. There's no stream api in here yet.How did you test it?
Link to a test plan if any -
The bridge builds, and
poe bridge-lintandpoe lintare clean. The Nexus system generator runs again on this pin and gives back the committed output. The client, visitor and external stream suites pass on the dev server the fixtures start. Nothing calls the new types yet. That starts in the next PR.