Conversation
The pinned Core carries the notification channel api, the bridge job and commands, and the five channel RPCs, so the regen brings them into Python. The submodule now names the fork, since upstream does not have the commit.
This was referenced Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR pins the Core that carries notification channels and regenerates the Python protos from it.
What changed?
temporalio/bridge/sdk-corepoints at the channel Core, and.gitmodulesnow namesmoedash/sdk-rust. Upstream doesn't have the commit, so a freshgit submodule updatewould fail on the old URL.poe gen-protosproduces from that pin: thenotification/v1package, the channel commands, events and failed causes,ChannelSubscriptionInfo, the five channel RPCs and their messages, theNotificationsReceivedjob and the two channel commands in the bridge protos. The pin forces the bridge visitor,services_generated.pyand theclient_rpc_generated.rsarms too.Part of AI-198 (epic AI-37).
Why?
The Python channel surface needs these types and RPCs before it can exist. Keeping the pin and its regen apart from the surface means the next PRs show only hand-written code. The Core here already handles the subscribe and unsubscribe commands and delivers the job, so the channel PRs on top can run every case without a gate.
How did you test it?
Link to a test plan if any -
The bridge builds, and
cargo clippy -- -D warningsandpoe lintare clean. A secondpoe gen-protosleaves the tree as committed. The client, activity, workflow, replayer and visitor suites pass on the dev server the fixtures start. Nothing calls the new types yet. That starts in the next PR.