refactor(orders): decompose OrdersController + ServiceRegistry factory map - #492
Open
Ibochkarev wants to merge 2 commits into
Open
refactor(orders): decompose OrdersController + ServiceRegistry factory map#492Ibochkarev wants to merge 2 commits into
Ibochkarev wants to merge 2 commits into
Conversation
…egistry factories Extract list/mutation/products/presenter services to shrink OrdersController below 1k LOC; register manager order services in DI. Replace ServiceRegistry switch/in_array wiring with explicit ServiceRegistryFactories map.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
Декомпозиция
OrdersController(#338): list/mutation/products/presenter вынесены вManagerOrder*сервисы, контроллер — тонкий HTTP-слой сResponse. РефакторингServiceRegistry(#345): явная карта фабрикServiceRegistryFactoriesвместоswitch/in_arrayдля wiring; зарегистрированы manager order сервисы иms3_extra_fields.Тип изменений
Связанные Issues
Closes #338
Closes #345
Как это было протестировано?
composer test:smoke)Конфигурация тестирования:
feat/issue-338-345-orders-registryСкриншоты (если применимо)
Чеклист
Дополнительные заметки
#338 AC
deleteProduct→data: null#345 AC
ServiceRegistryFactoryMapTest$modx->servicesНовые DI-ключи
ms3_manager_order_presenter,ms3_manager_order_list,ms3_manager_order_mutation,ms3_manager_order_products,ms3_manager_order_cost_recalculator,ms3_extra_fieldsFollow-up (не блокирует)
getLogs/finalize/recalculateCostоркестрацию из контроллераsuccess/error/getOrderLogbase для mutation/productsGridConfigController→ManagerOrderListService::getDirectFilterKeys()